20251014-WC_SAFE_SUM#9298
Merged
embhorn merged 6 commits intowolfSSL:masterfrom Oct 15, 2025
Merged
Conversation
…OF(), MIN_SINT_OF(), WC_SAFE_SUM_UNSIGNED(), and WC_SAFE_SUM_SIGNED().
…o fix false positive -Wnull-dereference. src/internal.c: suppress -Wnull-dereference locally in ProcessPeerCertParse() to fix false positive.
Contributor
Author
|
see ZD#20626 and ZD#20646 supersedes #9296 |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
2 similar comments
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
embhorn
reviewed
Oct 15, 2025
embhorn
requested changes
Oct 15, 2025
Member
embhorn
left a comment
embhorn
left a comment
There was a problem hiding this comment.
Cool that the NULL warning found some issue... Just the minor alignment comment
embhorn
approved these changes
Oct 15, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/types.h: addWC_WUR_INT(),MAX_UINT_OF(),MAX_SINT_OF(),MIN_SINT_OF(),WC_SAFE_SUM_UNSIGNED(), andWC_SAFE_SUM_SIGNED().src/ssl.c: fix overflow/overrun defect inwolfSSL_writev().src/internal.c: fix-Wnull-dereferenceinLoadCertByIssuer().wolfcrypt/src/asn.c: rearrange check for nullcnameinEncodeName()to fix false positive-Wnull-dereference.src/internal.c: suppress-Wnull-dereferencelocally inProcessPeerCertParse()to fix false positive.tested with
wolfssl-multi-test.sh ... pr-checkunderway now.